Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior seems broken on Samsung Galaxy Tab 2 #78

Closed
jpalermo opened this issue Jun 24, 2013 · 4 comments
Closed

Behavior seems broken on Samsung Galaxy Tab 2 #78

jpalermo opened this issue Jun 24, 2013 · 4 comments
Labels

Comments

@jpalermo
Copy link

When I try to draw on the canvas, I get a short line segment.

If I then try touching somewhere else I get a line that connects the end of the first line segment to my new touch point.

That behavior then continues, new tiny segment, connected to the previous segment.

This is happening on the default internet browser (and thus in web views from applications too). It does not happen in Chrome on the device though. Other signature libraries seem to work fine.

@thomasjbradley
Copy link
Contributor

I haven't seen that happen before. What version of Android is your device running?

@jpalermo
Copy link
Author

4.1.1

For some reason it seems like the touchmove event is not being fired when I'm moving. I've seen other signature libraries working on the device, I'll take a look and see if they do anything special.

BTW, the source is really well factored. Very clean and easy to read. Excellent job.

@jpalermo
Copy link
Author

Interesting, it seems that doing a preventDefault on the touchmove event fixes the problem.

I'm not really sure what the default action is for a touchmove event is though.

Mozilla seems to always call it in their touchmove examples, but they don't explain why.
https://developer.mozilla.org/en-US/docs/Web/Guide/DOM/Events/Touch_events

@thomasjbradley
Copy link
Contributor

Maybe that's to prevent it from scrolling.

p.s. Thanks for the compliments on the code.

jpalermo added a commit to jpalermo/signature-pad that referenced this issue Jun 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants