-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel by target #20
Cancel by target #20
Conversation
Just re-reading this section, I think it makes sense to clarify when the method is run. Also extended the example a bit & fixed some of the roadmap items :)
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
============================================
+ Coverage 86.98% 89.67% +2.68%
- Complexity 63 74 +11
============================================
Files 9 9
Lines 169 213 +44
============================================
+ Hits 147 191 +44
Misses 22 22
Continue to review full report at Codecov.
|
e5b93fa
to
f0367f2
Compare
I just noticed that i've gone with the double l in cancelled (which is aussie english). I'm wondering if we should keep it consistent and switch it to |
The American English version is two L also. I think Canada and Europe are 1. I’m fine with either, but agree it should be consistent. |
Grammarly seems to disagree I was thinking keep to american english? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests pass and code looks good
cc @thomasjohnkane