Fix sent_at typo in fillable array #50
Conversation
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=========================================
Coverage 97.89% 97.89%
Complexity 82 82
=========================================
Files 10 10
Lines 238 238
=========================================
Hits 233 233
Misses 5 5
Continue to review full report at Codecov.
|
|
@thomasjohnkane looks like travis is borked. I can't fix it as I don't have privs. |
|
@atymic and @thomasjohnkane any idea when this PR will be merged? Notification rescheduling is completely broken since the sent_at value is never reset. |
|
@thomasjohnkane can you fix Travis? I can't merge this without permissions (as the checks are not passing). |
| @@ -31,7 +31,7 @@ class ScheduledNotification extends Model | |||
| 'notification_type', | |||
| 'notification', | |||
| 'send_at', | |||
| 'sent', | |||
| 'sent_at', | |||
There was a problem hiding this comment.
while this should be corrected, we don't used mass assignment when rescheduling:
https://github.com/thomasjohnkane/snooze/blob/master/src/Models/ScheduledNotification.php#L147
So the cause of the bug must be elsewhere. Could you open an issue with more details?
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=========================================
Coverage 97.99% 97.99%
Complexity 77 77
=========================================
Files 10 10
Lines 249 249
=========================================
Hits 244 244
Misses 5 5
Continue to review full report at Codecov.
|
Co-authored-by: atymic <atymicq@gmail.com>
No description provided.