Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose Navigation Improvement. #67

Closed
1 task done
thomaskioko opened this issue Apr 12, 2023 · 0 comments · Fixed by #107
Closed
1 task done

Compose Navigation Improvement. #67

thomaskioko opened this issue Apr 12, 2023 · 0 comments · Fixed by #107
Labels
android Android related task/issues enhancement New feature or request

Comments

@thomaskioko
Copy link
Owner

thomaskioko commented Apr 12, 2023

Description

We currently have a module (navigation) responsible for setting up navigation. Each feature module should create a factory that implements ComposeNavigationFactory and define its route. This works fine, but we can improve it by moving the navigation logic away from the screens and potentially handling them in the ViewModel or StateMachines. Other than creating our implementation, we can use the following libraries:

@thomaskioko thomaskioko added enhancement New feature or request android Android related task/issues labels Apr 12, 2023
This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Android related task/issues enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant