Navigation Migration #107
Merged
Navigation Migration #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[iOS] Migrate to Decompose
…compose Migrate to Decompose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the core navigation implementation. We no longer use Jetpack Compose Navigation on Android.
I initially started out trying out Voyager but ended up switching to Decompose as it met my needs. The goal is to share Navigation/"ViewModel" and keep the UI's native. (Android - Jetpack Compose & iOS -SwiftUI). Voyager only seems to support Compose Multiplatform, hence the decision to go with Decompose.
With this change, we replaced Flowredux StateMachine, which acted as our "ViewModel," and are now using Decompose's components.
Migration PRs
Closes #67, closes #76, closes #83
MigrationDemo.mp4
iOS_Demo.mp4