Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we remove the Lovelace resource entry when installing 3.1.0 #159

Closed
sddgit opened this issue Nov 22, 2021 · 16 comments
Closed

Do we remove the Lovelace resource entry when installing 3.1.0 #159

sddgit opened this issue Nov 22, 2021 · 16 comments

Comments

@sddgit
Copy link

sddgit commented Nov 22, 2021

I see the instruction to change the way card-mod is installed with 3.1.0. Do I also need to remove the resource./hacsfiles/lovelace-card-mod/card-mod.js?hacstag=1909275243013 from the Lovelace dashboards resources?

Thanks for any tips.

@chriscolden
Copy link

came here to ask the same question.

Thanks

@anarion80
Copy link

Yes, looks like it. If you don't remove you will get an error in the log:
2021-11-22 09:07:45 ERROR (MainThread) [frontend.js.latest.202111090] https://ha/hacsfiles/lovelace-card-mod/card-mod.js?hacstag=190927524310:6:0 NotSupportedError: CustomElementRegistry.define: 'mod-card' has already been defined as a custom element
I removed it in my case and everything is fine.

@thomasloven
Copy link
Owner

The error can be safely ignored. I'll make sure it's removed for the next release.

@bcutter
Copy link

bcutter commented Nov 22, 2021

Sorry, created #161 before discovering this issue.

@chriscolden
Copy link

I've removed it from resources and it does seem to be happy, however, two issues come from the back of that.

  1. HACS complains the module isn't loaded.
  2. If you reinstall or upgrade it puts the resources entry back.

Are we suppose to keep removing this after every update and should the HACS be moaning like it does for me?

Thanks
Chris

@thomasloven
Copy link
Owner

No, you can leave it there and ignore the error.

@pergolafabio
Copy link

I think we need it on both places... If I remove it from the resources, seems the styles on the HA android app, are not applied ,i 'm having background issues then

@johnnysmithy852456
Copy link

johnnysmithy852456 commented Nov 23, 2021

I see the instruction to change the way card-mod is installed with 3.1.0. Do I also need to remove the resource./hacsfiles/lovelace-card-mod/card-mod.js?hacstag=1909275243013 from the Lovelace dashboards resources?

Thanks for any tips.

I can only find my card-mod.js in config/www/community/lovelace-card-mod/

@sddgit
Copy link
Author

sddgit commented Nov 23, 2021

It's in that place for me too. I figure the whole /hacsfiles thing must be some sort of symbolic reference, and that we should use what it says in the readme in the configuration.yaml file:

"You'll need to adjust that path according to where you have installed card-mod.js. If you installed through HACS, this is probably /hacsfiles/lovelace-card-mod/card-mod.js."

Not sure about that either though!

@thomasloven
Copy link
Owner

It should be whatever it says here: https://my.home-assistant.io/redirect/lovelace_resources/

@camochu
Copy link

camochu commented Nov 25, 2021

Anyone had tried if it's solved in release 3.1.1? I have 3.0.13 and waiting to update

@ahmaddxb
Copy link

Anyone had tried if it's solved in release 3.1.1? I have 3.0.13 and waiting to update

It is still there in 3.1.1

@rnotley
Copy link

rnotley commented Nov 28, 2021

Beyond the error posted here that you can find in the web browser console, I believe this issue also causes an error to be logged in Home Assistant.

2021-11-28 10:04:16 ERROR (MainThread) [frontend.js.latest.202111090] https://ha.___.com:8123/lovelace/0:0:0 Uncaught
image

I did limited testing, with and without the lovelace resource entry. With the resource entry, the error shows up when loading your dashboard. Without it, I don't see the error logged.

@dsegantx
Copy link

dsegantx commented Feb 5, 2022

@thomasloven Any update on if/when this will get suppressed? There are several related issues logged for this which likely can get closed in deference to this. Would like to see it resolved as I’m a bit OCD with error logging…. B^)

@thomasloven
Copy link
Owner

Should be gone now.

@pergolafabio
Copy link

Cool, thnx... Do we still need it at 2 places?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests