Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance warning is always showing on 2023.4.0b5 #267

Open
4 tasks done
kulmegil opened this issue Apr 4, 2023 · 10 comments
Open
4 tasks done

Performance warning is always showing on 2023.4.0b5 #267

kulmegil opened this issue Apr 4, 2023 · 10 comments

Comments

@kulmegil
Copy link

kulmegil commented Apr 4, 2023

My Home Assistant version:
2023.4.0b5

My lovelace configuration method (GUI or yaml):
gui

What I am doing:
loading tab

What I expected to happen:
Nothing. No bad performance warning in dev console when proper installation procedure is followed

What happened instead:
Performance warning is always shown in dev console

Looks like function getResources() from helpers.ts is returning invalid output

Minimal steps to reproduce:

frontend:
  extra_module_url:
    - /hacsfiles/lovelace-card-mod/card-mod.js

Error messages from the browser console:
card-mod-performace-warning


By putting an X in the boxes ([]) below, I indicate that I:

  • Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).

  • Have made sure I am using the latest version of the plugin.

  • Have followed the troubleshooting steps of the "Common Problems" section of https://github.com/thomasloven/hass-config/wiki/Lovelace-Plugins.

  • Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.

@ASNNetworks
Copy link

Also on 2023.4.1

@ildar170975
Copy link
Contributor

Confirmed, 2023.4.0

@nima-1102
Copy link

Also on 2023.4.5

@acshef
Copy link

acshef commented Jun 1, 2023

Looks like

export function getResources() {
is trying to split each script tag's innerText on newline, but that's not how they're formatted anymore:

> document.querySelectorAll("script")[3].innerText.trim()
'import("/hacsfiles/lovelace-card-mod/card-mod.js");import("/local/custom_icons/custom_icons.js");import("/hacsfiles/iconset.js");'

@ScottG489
Copy link

From debugging, I'm seeing roughly the same as you @acshef:

"/hacsfiles/lovelace-card-mod/card-mod.jsimport("/hacsfiles/iconset.js");"

Oddly no ;'s between the statements though. I wonder where those imports are coming from.

@Ali229
Copy link

Ali229 commented Jun 26, 2023

Still having this issue

@johntdyer
Copy link

Still seeing this issue

@nima-1102
Copy link

+1

Home Assistant 2023.9.3
Supervisor 2023.09.2
Operating System 10.5
Frontend 20230911.0 - latest

@nick-holmquist
Copy link

+1
Home Assistant 2023.9.3
Supervisor 2023.09.2
Operating System 10.5
Frontend 20230911.0 - latest

@Siroguh
Copy link

Siroguh commented Oct 16, 2023

Is this related to the poor performance as of late?
A simple screen tilt triggers an update and brings the card-mod styles.
(I'm sorry idk how to debug properly)

signal-2023-10-16-16-27-50-136.mp4

akomelj added a commit to akomelj/lovelace-card-mod that referenced this issue Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants