Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new enabled flag #33

Merged

Conversation

aldenquimby
Copy link
Contributor

This is my first PR, so please let me know if there's anything else you'd like to see in terms of docs or tests!

Why

How

  • new enabled config option is a flexible way to allow users to turn off plugin with invoke local
  • this is a common way to approach the problem, e.g. see serverless-domain-manager

@aldenquimby
Copy link
Contributor Author

aldenquimby commented Oct 5, 2023

@thomasmichaelwallace how does this PR look? My team is excited to use better-credentials once we have this flag. Thank you!

@thomasmichaelwallace
Copy link
Owner

@aldenquimby take a look at my suggestion - that .custom is not a guaranteed key.

And then we're good to go I think.

@aldenquimby
Copy link
Contributor Author

@thomasmichaelwallace I don't see your suggestion, but I can guess at it based on that comment! Just pushed an update that makes .custom optional

@thomasmichaelwallace thomasmichaelwallace merged commit ba3e4f8 into thomasmichaelwallace:main Oct 16, 2023
@aldenquimby aldenquimby deleted the enabled-flag branch October 17, 2023 12:41
@aldenquimby
Copy link
Contributor Author

Thanks @thomasmichaelwallace ! Excited for this to release 🚀

@thomasmichaelwallace
Copy link
Owner

Now released - https://github.com/thomasmichaelwallace/serverless-better-credentials/releases/tag/v1.3.0

@aldenquimby
Copy link
Contributor Author

@thomasmichaelwallace thank you! Just upgraded and it looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants