-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge_sorter::minimum_memory_phase_X() is lower than actual memory requirements #250
Comments
This might be relevant: #206 |
3 tasks
SSoelvsten
added a commit
to SSoelvsten/adiar
that referenced
this issue
Dec 27, 2021
SSoelvsten
added a commit
to SSoelvsten/adiar
that referenced
this issue
Dec 27, 2021
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behaviour
Based on their names, I would expect
minimum_memory_phase_1()
,minimum_memory_phase_2()
, andminimum_memory_phase_3()
to compute the least amount of memory one should provide the sorter for it to be happy. Maybe this in itself is a misunderstanding, but then maybe some documentation should be added to these functions?Actual Behaviour
minimum_memory_phase_1()
causes a "Not enough phase 1 memory for 128 KB items and an open stream!" warning printed to the console.minimum_memory_phase2()
andminimum_memory_phase3()
seem to always return 0. This does not have any impact on the sorter, as it silently takes more than given (I assume?)Minimal example
When running this (also with much more than just 128 MiB of memory) on
master
will cause the following warning to be printed:Running the same on
fix-sort-large-items
makes this estimate even more undershoot the actual value.The text was updated successfully, but these errors were encountered: