Server join broken #7

f4n74z14 · 2023-04-07T04:38:53Z

Hello! After the latest changes, joining the game broke for me.

Stacktrace:

[10:45:03] [Netty Server IO #1/WARN]: java.lang.reflect.InvocationTargetException
[10:45:03] [Netty Server IO #1/WARN]: 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[10:45:03] [Netty Server IO #1/WARN]: 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[10:45:03] [Netty Server IO #1/WARN]: 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[10:45:03] [Netty Server IO #1/WARN]: 	at java.lang.reflect.Method.invoke(Method.java:498)
[10:45:03] [Netty Server IO #1/WARN]: 	at dev.thomazz.pledge.util.ChannelHelper.encodeAndCompress(ChannelHelper.java:19)
[10:45:03] [Netty Server IO #1/WARN]: 	at dev.thomazz.pledge.network.handler.PacketFrameOutboundHeadHandler.flush(PacketFrameOutboundHeadHandler.java:88)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeFlush0(AbstractChannelHandlerContext.java:776)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeFlush(AbstractChannelHandlerContext.java:768)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.channel.AbstractChannelHandlerContext.flush(AbstractChannelHandlerContext.java:749)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.channel.ChannelOutboundHandlerAdapter.flush(ChannelOutboundHandlerAdapter.java:115)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeFlush0(AbstractChannelHandlerContext.java:776)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.channel.AbstractChannelHandlerContext.invokeFlush(AbstractChannelHandlerContext.java:768)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.channel.AbstractChannelHandlerContext.access$1500(AbstractChannelHandlerContext.java:38)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.channel.AbstractChannelHandlerContext$16.run(AbstractChannelHandlerContext.java:756)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:463)
[10:45:03] [Netty Server IO #1/WARN]: 	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884)
[10:45:03] [Netty Server IO #1/WARN]: 	at java.lang.Thread.run(Thread.java:750)
[10:45:03] [Netty Server IO #1/WARN]: Caused by: java.lang.ClassCastException: io.netty.buffer.PooledUnsafeDirectByteBuf cannot be cast to net.minecraft.server.v1_12_R1.Packet
[10:45:03] [Netty Server IO #1/WARN]: 	at net.minecraft.server.v1_12_R1.PacketEncoder.encode(PacketEncoder.java:17)
[10:45:03] [Netty Server IO #1/WARN]: 	... 19 more

Tested on: git-Paper-1618 (MC: 1.12.2) ; git-Paper-498 (MC: 1.19.4)

Also the problem persists with and w/o ViaVersion, ProtocolLib.

Thanks!

ScatDev · 2023-04-12T22:35:46Z

I also started getting this on 1.8

ThomasOM · 2023-04-13T22:26:20Z

I am currently working on a fix for this, you can use version 2.2 for the moment

ThomasOM · 2023-04-13T23:18:09Z

As it stands now I am unable to reproduce it, on paper current paper version, no plugins with only pledge active

ThomasOM · 2023-04-13T23:22:14Z

I force deployed a new build to the maven repository, let me know if this fixes it.
If not please provide me with the following information:

Bungeecoord enabled / disabled
Compression threshold
Last server log file

ThomasOM · 2023-04-15T01:49:15Z

I've confirmed this as fixed on the latest build with another user, let me know if this is also resolved on the latest build

f4n74z14 · 2023-04-19T16:50:35Z

Hello! Sorry, misclick.

I've tested on the lastest build (2.3 from repo) and the problem still persists for me

BungeeCord mode is disabled.
network-compression-threshold=0
The lastest log: https://mclo.gs/nCGvg9O

ThomasOM · 2023-04-20T23:29:26Z

Hello, this should be resolved in update 2.4. Let me know if you're still experiencing issues.

f4n74z14 · 2023-04-21T22:11:55Z

Yup, now it works but incompatible with ProtocolLib. 😵
Edit: sometimes it cannot make handler even w/o ProtocolLib

[05:31:01 ERROR]: Could not pass event PlayerLoginEvent to PledgeTest v1.0
org.bukkit.event.EventException: null
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:72) ~[patched_1.12.2.jar:git-Paper-1620]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:78) ~[patched_1.12.2.jar:git-Paper-1620]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[patched_1.12.2.jar:git-Paper-1620]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:513) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.PlayerList.attemptLogin(PlayerList.java:565) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.LoginListener.b(LoginListener.java:152) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.LoginListener.e(LoginListener.java:68) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.NetworkManager.a(NetworkManager.java:273) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.ServerConnection.c(ServerConnection.java:150) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:948) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:423) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:774) ~[patched_1.12.2.jar:git-Paper-1620]
        at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:666) ~[patched_1.12.2.jar:git-Paper-1620]
        at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: java.lang.RuntimeException: Could not get channel for player: f4n74z14
        at dev.thomazz.pledge.channel.ReflectiveChannelAccess.getChannel(ReflectiveChannelAccess.java:68) ~[?:?]
        at dev.thomazz.pledge.PledgeImpl.onPlayerLogin(PledgeImpl.java:213) ~[?:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor11.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:70) ~[patched_1.12.2.jar:git-Paper-1620]
        ... 13 more
Caused by: java.lang.NoSuchFieldException: Could not find field in class net.minecraft.server.v1_12_R1.HandshakeListener with names [EntityPlayer]
        at dev.thomazz.pledge.util.ReflectionUtil.getFieldByClassNames(ReflectionUtil.java:21) ~[?:?]
        at dev.thomazz.pledge.channel.ReflectiveChannelAccess.getChannel(ReflectiveChannelAccess.java:57) ~[?:?]
        at dev.thomazz.pledge.PledgeImpl.onPlayerLogin(PledgeImpl.java:213) ~[?:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor11.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:70) ~[patched_1.12.2.jar:git-Paper-1620]
        ... 13 more

Edit 2: This happens if player kicked on login state

  [03:49:58 WARN]: [io.netty.util.concurrent.AbstractEventExecutor] A task raised an exception. Task: dev.thomazz.pledge.PlayerHandler$$Lambda$1066/0x00000008015cecd8@2516655c
  java.lang.RuntimeException: java.lang.NullPointerException: Cannot invoke "io.netty.channel.ChannelHandlerContext.pipeline()" because "ctx" is null
    at dev.thomazz.pledge.PlayerHandler.lambda$tickEnd$1(PlayerHandler.java:131) ~[?:?]
    at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) ~[patched_1.12.2.jar:git-Paper-1620]
    at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404) ~[patched_1.12.2.jar:git-Paper-1620]
    at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:463) ~[patched_1.12.2.jar:git-Paper-1620]
    at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) ~[patched_1.12.2.jar:git-Paper-1620]
    at java.lang.Thread.run(Thread.java:833) [?:?]
    Caused by: java.lang.NullPointerException: Cannot invoke "io.netty.channel.ChannelHandlerContext.pipeline()" because "ctx" is null
    at dev.thomazz.pledge.network.PacketFrameOutboundHeadHandler.drain(PacketFrameOutboundHeadHandler.java:109) ~[?:?]
    at dev.thomazz.pledge.PlayerHandler.lambda$tickEnd$1(PlayerHandler.java:129) ~[?:?]
    ... 5 more

ThomasOM · 2023-04-23T21:02:01Z

First exception seems very weird since it seems like a handshake listener instead of a login listener is found even though the login listener is called? The second issue should be fixed in 8e0dff8, feel free to verify if your issue is resolved.

f4n74z14 · 2023-04-25T17:05:48Z

First exception seems very weird since it seems like a handshake listener instead of a login listener is found even though the login listener is called?

Yes, that weird, but sometimes it happens.

ThomasOM · 2023-04-26T05:37:13Z

@gbomexify Create a new issue for this

ThomasOM · 2023-05-29T03:07:52Z

Closing this now, if any other problems are encountered feel free to create another issue

ThomasOM added the bug Something isn't working label Apr 14, 2023

f4n74z14 closed this as completed Apr 19, 2023

f4n74z14 reopened this Apr 19, 2023

ThomasOM closed this as completed May 29, 2023

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Server join broken #7

Server join broken #7

f4n74z14 commented Apr 7, 2023

ScatDev commented Apr 12, 2023 •

edited

Loading

ThomasOM commented Apr 13, 2023

ThomasOM commented Apr 13, 2023

ThomasOM commented Apr 13, 2023

ThomasOM commented Apr 15, 2023

f4n74z14 commented Apr 19, 2023 •

edited

Loading

ThomasOM commented Apr 20, 2023

f4n74z14 commented Apr 21, 2023 •

edited

Loading

ThomasOM commented Apr 23, 2023

f4n74z14 commented Apr 25, 2023

ThomasOM commented Apr 26, 2023

ThomasOM commented May 29, 2023

Server join broken #7

Server join broken #7

Comments

f4n74z14 commented Apr 7, 2023

Thanks!

ScatDev commented Apr 12, 2023 • edited Loading

ThomasOM commented Apr 13, 2023

ThomasOM commented Apr 13, 2023

ThomasOM commented Apr 13, 2023

ThomasOM commented Apr 15, 2023

f4n74z14 commented Apr 19, 2023 • edited Loading

ThomasOM commented Apr 20, 2023

f4n74z14 commented Apr 21, 2023 • edited Loading

ThomasOM commented Apr 23, 2023

f4n74z14 commented Apr 25, 2023

ThomasOM commented Apr 26, 2023

ThomasOM commented May 29, 2023

ScatDev commented Apr 12, 2023 •

edited

Loading

f4n74z14 commented Apr 19, 2023 •

edited

Loading

f4n74z14 commented Apr 21, 2023 •

edited

Loading