Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paper Theme alert variables are circumvented in bootswatch.less #632

Closed
robertsoniv opened this issue Feb 9, 2017 · 0 comments
Closed

Paper Theme alert variables are circumvented in bootswatch.less #632

robertsoniv opened this issue Feb 9, 2017 · 0 comments

Comments

@robertsoniv
Copy link
Contributor

robertsoniv commented Feb 9, 2017 •
edited

Shouldn't these selectors be using the values for their respective @alert-{{type}}-{{property}} variables that are defined in _variables.less?

If my assumptions are correct I think line 526 of _bootswatch.less should also be deleted.

I would be happy to make a PR with the fix!
@robertsoniv robertsoniv mentioned this issue Feb 10, 2017
Merged
thomaspark added a commit that referenced this issue Feb 10, 2017
@thomaspark
Merge pull request #633 from robertsoniv/paper-theme-patch
01e94d6 
Paper: refactor @alert-{{type}}-{{property}} variables #632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomaspark @robertsoniv