Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM package v3.3.7 doesn't contain solar files #643

Closed
chriswhite199 opened this issue Mar 20, 2017 · 5 comments
Closed

NPM package v3.3.7 doesn't contain solar files #643

chriswhite199 opened this issue Mar 20, 2017 · 5 comments
Labels
wontfix

Comments

@chriswhite199
Copy link

The NPM package for v3.3.7 doesn't contain the solar files:

curl -s https://registry.npmjs.org/bootswatch/-/bootswatch-3.3.7.tgz | tar tvz | grep -E '(cyborg|solar)'
-rw-r--r--  0 501    20       3924 Jul 30  2016 package/cyborg/_bootswatch.scss
-rw-r--r--  0 501    20      30963 Jul 30  2016 package/cyborg/_variables.scss
-rw-r--r--  0 501    20     149812 Jul 30  2016 package/cyborg/bootstrap.css
-rw-r--r--  0 501    20     125625 Jul 30  2016 package/cyborg/bootstrap.min.css
-rw-r--r--  0 501    20       3961 Jul 30  2016 package/cyborg/bootswatch.less
-rw-r--r--  0 501    20      25410 Dec  6  2014 package/cyborg/thumbnail.png
-rw-r--r--  0 501    20      27361 Jul 30  2016 package/cyborg/variables.less
@lord-alfred
Copy link

lord-alfred commented Apr 13, 2017 •
edited
Loading

Confirm! Also get a error when compiling SASS this theme.

@Drapegnik
Copy link

+1

@extend1994 extend1994 mentioned this issue Jul 19, 2017
Closed
@svenevs
Copy link

svenevs commented Jul 21, 2017

So fixing this ex-post-facto isn't really simple assuming npm (don't use it, don't know) is using the actual tags on GitHub, tag v3.3.7 is the problem.

I'm not sure but I think this could be fixed with a v3.3.7+1 tag? Previous tags had similar things:

v3.3.5
v3.3.5+1
v3.3.5+2
v3.3.5+3
v3.3.5+4
v3.3.6
v3.3.6+1
v3.3.6+2

Not sure how things are getting distributed where, but solar is way too good to not be in there 😊

@svenevs svenevs mentioned this issue Jul 21, 2017
Merged
@thomaspark
Copy link
Owner

Unfortunately npm will strip out the build number (aka everything after the +), unless something changed recently.

ryan-roemer pushed a commit to ryan-roemer/sphinx-bootstrap-theme that referenced this issue Jul 23, 2017
@svenevs @ryan-roemer
Upgrade to bootstrap / bootswatch v3.3.7 (#164)
f7c86aa 
- minor doc fixes
    - I believe I got all 3.3.6 into 3.3.7
    - suggestion to use bs3 over 2
- more specific directions on how to upgrade in future
    - missing documentation of `static/bootstrap-sphinx.css_t` for upgrades
    - much more description of what should go down in `TODO.rst`
        - modified the **epic** `tar` packaging to be more explicit (anybody who has `egrep` aliased can't use the original solution)
- fixed `Makefile` to actually use `python3`
    - added simple option for port override (I'm currently running a mission critical app on `8000` xD)
- fixed `requirements.txt` to allow e.g. `sphinx==1.6.2` or higher
    - `setup.py` has neither of these dependencies?
    - if you add them, you'll need to treat python 2 and 3 separately because of fabric?

#### Notes:

- Candidate to close #149
- Officially the `solar` theme is not in the `v3.3.7` bootswatch tag, see [this issue](thomaspark/bootswatch#643)
    - Just added it manually from the main page
- I don't think you actually want to include the `custom` theme, I'm pretty sure it's either an artifact or a basis for creating your own.
- Changed a few locations referring to the now nonexistent `amelia` theme
 
#### Questions:

1. There is a rather long commented out section in `TODO.rst`.  Might be worth deleting?
2. See changes to `README.rst`, in particular the added `.. warning::`.  The question: I didn't really understand what was going on with #159 because I didn't have any trouble building with `sphinx==1.5.1` or `1.5.5` etc.  Basically, if it's actually a hard requirement then maybe the verbiage is fine, but if not then it's too strong?
3. This is not a "you" problem, but when viewing the source of generated pages I noticed all of the javascript gets loaded at the beginning in the `<meta>` rather than at the bottom.  I know next to nothing about front-end, but those are supposed to be loaded last right (sphinx is doing this, not you)?

Happy to undo / revise any of the included, thanks again for the theme 😄
@stale
Copy link

stale bot commented Apr 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 13, 2018
@stale stale bot closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thomaspark @chriswhite199 @lord-alfred @svenevs @Drapegnik