New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all devDependencies and assorted fixes #986
Conversation
Thanks for taking a stab at this. The build process is definitely in need of refresh, as it's out of sync with Bootstrap and has room for some major optimizations. Will be nice to get this all resolved in v4 before work on v5 starts. |
I think this should be enough of improvement for now, but please consider the points in my OP. The build process could be simplified a lot by not allowing to build each theme separately. I don't have the time to look into this though. Alternatively, you could just switch to npm scripts with building everything at once. |
@thomaspark I rebased this. Please check the generated files' diff and my points above. BTW if you want you can join our Slack channel so that we can communicate faster if needed :) |
Here's the npm pack diff: v4.5.2
This branch
|
* Add @lodder/grunt-postcss * Specify `precision: 6` for node-sass like upstream * Add clean-css * Update browserslistc config from upstream * Remove engines version since the consumers of the package are not affected by the Node.js version * Switch to explicitly using `grunt.config`'s methods
This is awesome, thanks for your work on this @XhmikosR! |
precision: 6
for node-sass like upstreamgrunt.config
's methodsDraft because:
IMHO the Gruntfile needs some refactoring. There are a few issues I noticed: