Fix for nilaway warnings

[sarvsav]

Why: nilaway identified issues related to nil panics, and for better user experience those needs to be fixed

How: By adding checks for nil value

Tags: nilaway, panics

Changes include

• Bugfix (non-breaking change that solves an issue)

Closes issue(s)

Resolve #1420

Checklist

• I have tested this code
• I have followed the contributing guide

[netlify]

✅ Deploy Preview for go-feature-flag-doc-preview canceled.

Name	Link
🔨 Latest commit	0d61421
🔍 Latest deploy log	https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/65dc9bd16cec2a0007fd0fdd

[sarvsav]

nilaway updated report:

$ nilaway.exe -include-pkgs="github.com/thomaspoignant/go-feature-flag" ./...
C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\feature_flag.go:231:9: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
        - C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\feature_flag.go:59:5: nilable value assigned into global variable `ff`      
        - C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\feature_flag.go:236:9: global variable `ff` used as receiver to call `GetCacheRefreshDate()`
        - C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\feature_flag.go:231:9: read by method receiver `g` accessed field `cache`   

C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\exporter\data_exporter_test.go:58:18: error: Potential nil panic detected. Observed nil flow from source to dereference point: 
        - C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\exporter\data_exporter_test.go:58:18: unassigned variable `inputEvents` sliced into

C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\exporter\data_exporter_test.go:78:18: error: Potential nil panic detected. Observed nil flow from source to dereference point:
        - C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\exporter\data_exporter_test.go:78:18: unassigned variable `inputEvents` sliced into

C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\exporter\data_exporter_test.go:104:18: error: Potential nil panic detected. Observed nil flow from source to dereference point:
        - C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\exporter\data_exporter_test.go:104:18: unassigned variable `inputEvents` sliced into

C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\exporter\data_exporter_test.go:130:18: error: Potential nil panic detected. Observed nil flow from source to dereference point:
        - C:\Users\ss\Projects\Go\src\github.com\sarvsav\go-feature-flag\exporter\data_exporter_test.go:130:18: unassigned variable `inputEvents` sliced into`

The above reporting is false positive from the tool.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.88%. Comparing base (68bbd39) to head (0d61421).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
+ Coverage   87.75%   87.88%   +0.12%     
==========================================
  Files          77       77              
  Lines        3627     3640      +13     
==========================================
+ Hits         3183     3199      +16     
+ Misses        361      358       -3     
  Partials       83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thomaspoignant]

This looks great, I've proposed some NIT changes.

[sarvsav]

This looks great, I've proposed some NIT changes.

Thank you for the quick review, I am addressing the coverage also by writing the test cases. I will share the updated PR soon and remove WIP from the title once is ready for review again.

[sonarcloud]

Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud