Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remove file #1607

Merged
merged 3 commits into from Mar 4, 2024
Merged

Conversation

DucVuMinh
Copy link
Contributor

@DucVuMinh DucVuMinh commented Mar 3, 2024

Description

  • Problem: do not close and remove the file after reading content
  • Close the file then remove it

Changes include

  • Bugfix close file

Closes issue(s)

Resolve #1598

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Mar 3, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 3d5d8a6
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/65e5cfd1ca12020008e30565

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (117c1ef) to head (3d5d8a6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1607      +/-   ##
==========================================
+ Coverage   88.00%   88.01%   +0.01%     
==========================================
  Files          77       77              
  Lines        3650     3654       +4     
==========================================
+ Hits         3212     3216       +4     
  Misses        354      354              
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DucVuMinh super nice addition it was really needed, I don't even know how I forgot about that 🤦

Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit f3471db into thomaspoignant:main Mar 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential memory leak when using s3 retriever
2 participants