Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic concurrent map writes when constructing metadata #1663

Merged
merged 3 commits into from Mar 21, 2024

Conversation

kbiits
Copy link
Contributor

@kbiits kbiits commented Mar 20, 2024

Description

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #1662

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 979ad5d
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/65fabd28ae8c2a0008869e21

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (5b0868c) to head (979ad5d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1663   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          77       77           
  Lines        3669     3669           
=======================================
  Hits         3223     3223           
  Misses        360      360           
  Partials       86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbiits kbiits force-pushed the main branch 2 times, most recently from 80d7234 to bf28f69 Compare March 20, 2024 03:42
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, good catch 🙌
Thanks a lot for this contribution, I will be available in the next version (probably this week).

@thomaspoignant thomaspoignant merged commit ef6c364 into thomaspoignant:main Mar 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) Panic when call getVariation with rules evaluated in parallel
2 participants