Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S3 retriever.go mechanism #1665

Merged
merged 3 commits into from Mar 24, 2024
Merged

Conversation

pirlomnfw
Copy link
Contributor

@pirlomnfw pirlomnfw commented Mar 20, 2024

Description

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit a337e3f
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/65fc0656fed0490008a8a03a

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base (ef6c364) to head (a337e3f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1665      +/-   ##
==========================================
+ Coverage   87.84%   87.97%   +0.13%     
==========================================
  Files          77       77              
  Lines        3669     3660       -9     
==========================================
- Hits         3223     3220       -3     
+ Misses        360      356       -4     
+ Partials       86       84       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@thomaspoignant thomaspoignant merged commit 7e74332 into thomaspoignant:main Mar 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants