Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFREP: Add missing flagKey in error responses + adding tests #1760

Merged
merged 1 commit into from Apr 15, 2024

Conversation

thomaspoignant
Copy link
Owner

Description

OFREP: Add missing flagKey in error responses + adding tests

Changes include

  • Bugfix (non-breaking change that solves an issue)

Closes issue(s)

Resolve #1759
Resolve #1638

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 82a20c0
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/661d944a6f0c610008bc5228

Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.97%. Comparing base (2a35d96) to head (82a20c0).

Files Patch % Lines
cmd/relayproxy/ofrep/evaluate.go 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1760      +/-   ##
==========================================
- Coverage   88.99%   88.97%   -0.03%     
==========================================
  Files          77       79       +2     
  Lines        2989     3119     +130     
==========================================
+ Hits         2660     2775     +115     
- Misses        245      257      +12     
- Partials       84       87       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaspoignant thomaspoignant merged commit add7232 into main Apr 15, 2024
20 of 22 checks passed
@thomaspoignant thomaspoignant deleted the ofrep-1759 branch April 15, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bug) OFREP error should contain flag key Add tests for OFREP endpoints
1 participant