-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jitter to accept randomization of the retrieval time #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Codecov Report
@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 89.50% 89.52% +0.01%
==========================================
Files 66 66
Lines 3002 3016 +14
==========================================
+ Hits 2687 2700 +13
- Misses 257 258 +1
Partials 58 58
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an option to avoid having true periodicity when retrieving your flags.
It is useful to avoid having spike on your flag configuration storage in case your application is starting multiple instances at the same time.
We ensure a deviation that is maximum + or - 10% of your polling interval.
Default: false
Changes include
Closes issue(s)
Resolve #942
Checklist
README.md
and/website/docs
)