fix #176 - allow adds when there is no matching target in an array #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in an array, but the array exists
|
Kudos, SonarCloud Quality Gate passed!
|
thomaspoignant
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Hello @barryhagan,
Thank you for your contribution this is super great.
I will release a new version v0.5.7 Today with this fix.
| @@ -241,7 +241,7 @@ function applyAddOrReplaceOperation<T extends ScimResource>(scimResource: T, pat | |||
| // code 400 and a "scimType" error code of "noTarget". | |||
| const isReplace = patch.op.toLowerCase() === 'replace'; | |||
| if (isReplace && matchFilter.length === 0) { | |||
| throw new NoTarget(patch.value); | |||
| throw new NoTarget(patch.path); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix to allow PATCH operations to add values to multi-valued attributes when using a path filter.
Changes include
There are two tests that were changed to expect a NoTarget exception instead of InvalidScimPatchOp. I'm not sure if you consider that throw behavior change breaking.
Closes issue(s)
Resolve #176
Checklist