Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default behavior for treatMissingAsAdd #448

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Change the default behavior for treatMissingAsAdd #448

merged 2 commits into from
Jul 28, 2023

Conversation

thomaspoignant
Copy link
Owner

Description

⚠️ Changing the default behavior to map the RFC.

Considering the comment of @yubing24 here we will switch the default behavior of treatMissingAsAdd from false to true.

Changes include

  • Breaking changes (change that is not backward-comptible and/or changes current functionality)

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the Readme
  • I have followed the contributing guide

@thomaspoignant
Change the default behavior for treatMissingAsAdd
96e975c 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant mentioned this pull request Jul 28, 2023
Closed
@thomaspoignant
Add test for default version + with the {treatMissingAsAdd: false}
ca8212a 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant merged commit 45ab33a into master Jul 28, 2023
7 checks passed
@thomaspoignant thomaspoignant deleted the change-default-treat-missing-as-add branch July 28, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomaspoignant thomaspoignant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thomaspoignant