This repository has been archived by the owner on Jul 11, 2018. It is now read-only.
Remove hardcoded packages and replace with modules #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. I think make is needed in order to support rhel-like systems, but I'll go ahead and release this as is. Thanks! |
thomasvandoren
added a commit
that referenced
this pull request
Dec 6, 2012
Remove hardcoded packages and replace with modules
|
Released in version 0.0.9. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaced the Package resources for wget and build-essential with existing puppet modules from the forge.
This may seem a bit of a faff but it aids module reuse, here's the problem I ran into.
This may also have the knock on effect of letting the module support other operating systems. I haven't tested it but from a quick read the module doesn't appear to do anything platform specific except install build-essential.