perf: speed up RegExp with character classes

thomasvantuycom · Sep 28, 2023 · 35e2943 · 35e2943
1 parent 6224a39
commit 35e2943
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/lib/replace.js b/lib/replace.js
@@ -3,15 +3,7 @@ import escapeStringRegexp from 'escape-string-regexp';
 export default function replace(contents, manifest) {
 	let newContents = contents;
 	for (const [originalPath, revisionedPath] of Object.entries(manifest)) {
-		const FRONT_DELIMITERS = ['"', '\'', '\\s', ',', '\\(', '\\/', '=', '^', '%2F'];
-		const BACK_DELIMITERS = ['"', '\'', '\\s', ',', '\\)', '\\\\', '\\?', '#', '$', '&', '>'];
-
-		const regexp = new RegExp(
-			`(?<=${FRONT_DELIMITERS.join('|')})${escapeStringRegexp(
-				originalPath,
-			)}(?=${BACK_DELIMITERS.join('|')})`,
-			'g',
-		);
+		const regexp = new RegExp(`(?<![\\w-])${escapeStringRegexp(originalPath)}(?![\\w.])`, 'g');
 
 		newContents = newContents.replace(regexp, revisionedPath);
 	}