Skip to content

Commit

Permalink
Modify error handlings
Browse files Browse the repository at this point in the history
  • Loading branch information
thombashi committed Mar 21, 2020
1 parent 00d355a commit 5af0b1e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion simplesqlite/_sanitizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def _validate_table_name(self, table_name: str) -> None:
validate_sqlite_table_name(table_name)
except ValidationError as e:
if (
e.reason == ErrorReason.RESERVED_NAME and not e.reusable_name
e.reason == ErrorReason.RESERVED_NAME and e.reusable_name is False
) or e.reason == ErrorReason.INVALID_CHARACTER:
raise InvalidTableNameError(e)
elif e.reason == ErrorReason.RESERVED_NAME:
Expand Down
2 changes: 1 addition & 1 deletion simplesqlite/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def to_query(self) -> str:
try:
validate_sqlite_attr_name(name)
except ValidationError as e:
if e.reason == ErrorReason.RESERVED_NAME and not e.reusable_name:
if e.reason == ErrorReason.RESERVED_NAME and e.reusable_name is False:
need_quote = True
elif e.reason in (
ErrorReason.RESERVED_NAME,
Expand Down
4 changes: 2 additions & 2 deletions test/test_validator.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def test_exception_reserved_invalid_name(self, value):
validate_sqlite_table_name(value)
except ValidationError as e:
assert e.reason == ErrorReason.RESERVED_NAME
assert not e.reusable_name
assert e.reusable_name is False


class Test_validate_sqlite_attr_name:
Expand Down Expand Up @@ -306,4 +306,4 @@ def test_exception_reserved_invalid_name(self, value):
validate_sqlite_attr_name(value)
except ValidationError as e:
assert e.reason == ErrorReason.RESERVED_NAME
assert not e.reusable_name
assert e.reusable_name is False

0 comments on commit 5af0b1e

Please sign in to comment.