Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sanitize_filename truncation #48

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Fix sanitize_filename truncation #48

merged 2 commits into from
Jun 24, 2024

Conversation

7x11x13
Copy link
Contributor

@7x11x13 7x11x13 commented Jun 18, 2024 •
edited
Loading

Fixes #47

@7x11x13 7x11x13 changed the title Fix filename_sanitize truncation (#47) Fix filename_sanitize truncation Jun 18, 2024
@7x11x13 7x11x13 changed the title Fix filename_sanitize truncation Fix sanitize_filename truncation Jun 18, 2024
thombashi
thombashi requested changes Jun 23, 2024
View reviewed changes
pathvalidate/_common.py Outdated Show resolved Hide resolved
thombashi
thombashi approved these changes Jun 24, 2024
View reviewed changes
Copy link
Owner

@thombashi thombashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for your pull request.

@thombashi thombashi merged commit 92e2f9d into thombashi:master Jun 24, 2024
43 of 44 checks passed
@7x11x13 7x11x13 deleted the multibyte-sanitization branch June 28, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thombashi thombashi thombashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

max_len with sanitize_filename behaves incorrectly with multi-byte unicode chars
2 participants
@7x11x13 @thombashi