Skip to content

Commit

Permalink
Add interfaces to set loading encoding
Browse files Browse the repository at this point in the history
  • Loading branch information
thombashi committed Aug 19, 2017
1 parent c44cd0f commit ecc0a6e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions pytablereader/factory/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ def source(self):

return self._source

def __init__(self, source):
def __init__(self, source, encoding=Default.ENCODING):
self._source = source
self._encoding = Default.ENCODING
self._encoding = encoding

@abc.abstractmethod
def create_from_path(self): # pragma: no cover
Expand Down
6 changes: 3 additions & 3 deletions pytablereader/loadermanager/_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from __future__ import absolute_import

import typepy

from .._constant import Default
from ..factory import TableFileLoaderFactory
from ._base import TableLoaderManager

Expand Down Expand Up @@ -41,8 +41,8 @@ class TableFileLoader(TableLoaderManager):
* :py:meth:`pytablereader.factory.TableFileLoaderFactory.create_from_path`
"""

def __init__(self, file_path, format_name=None):
loader_factory = TableFileLoaderFactory(file_path)
def __init__(self, file_path, format_name=None, encoding=Default.ENCODING):
loader_factory = TableFileLoaderFactory(file_path, encoding=encoding)

if typepy.is_not_null_string(format_name):
loader = loader_factory.create_from_format_name(format_name)
Expand Down

0 comments on commit ecc0a6e

Please sign in to comment.