Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some old Python <= 3.3 code #11

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 14, 2019

EOL Python 3.3 was dropped in e409b62.

This PR removes some redundant requirements for Python <= 3.3, and makes sure not to install for users with Python 3.3.

@thombashi thombashi self-requested a review January 14, 2019 23:04
Copy link
Owner

@thombashi thombashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

I will withhold to merge this PR until Python 2.7 become EOL.
This is because enum34/ipaddress packages are also still required for Python 2.7 compatibility.

@thombashi thombashi self-assigned this Jan 14, 2019
@hugovk
Copy link
Contributor Author

hugovk commented Jan 14, 2019

Oh yes, good point.

Tomorrow I will update this to only include 0aec446.

@hugovk
Copy link
Contributor Author

hugovk commented Feb 23, 2019

Sorry for the delay, now updated to drop Python 3.3 but retain Python 2.7.

@thombashi thombashi merged commit f4af28e into thombashi:master Feb 25, 2019
@thombashi
Copy link
Owner

Thank you for the update. merged.

@hugovk hugovk deleted the rm-3.3 branch February 25, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants