Modify to accept underscore-character for attribute names

requirements/requirements.txt

@@ -2,7 +2,7 @@ appconfigpy>=0.0.2
 click>=6.7
 logbook
 path.py
-pytablereader>=0.13.3
+pytablereader>=0.13.4
 SimpleSQLite>=0.15.0
 sqliteschema>=0.9.3
 typepy>=0.0.20

test/dataset.py

@@ -258,6 +258,26 @@ def valid_excel_file():
     return str(file_path)
 
 
+def valid_excel_file_1():
+    file_path = "valid_underscore.xlsx"
+    workbook = xlsxwriter.Workbook(str(file_path))
+
+    worksheet = workbook.add_worksheet("sheet_a")
+    table = [
+        ["data", "_data", "da_ta", "data_"],
+        [1, 0.0, "a", "aaaa"],
+        [2, 0.1, "b", "bbbb"],
+        [3, 0.2, "c", "cccc"],
+    ]
+    for row_idx, row in enumerate(table):
+        for col_idx, item in enumerate(row):
+            worksheet.write(row_idx, col_idx, item)
+
+    workbook.close()
+
+    return str(file_path)
+
+
 def invalid_excel_file_1():
     file_path = "invalid.xlsx"
     workbook = xlsxwriter.Workbook(file_path)

test/test_file_subcommand.py

@@ -32,6 +32,7 @@
     valid_tsv_file,
     invalid_tsv_file,
     valid_excel_file,
+    valid_excel_file_1,
     invalid_excel_file_1,
     invalid_excel_file_2,
     valid_html_file,
@@ -167,6 +168,20 @@ def test_abnormal_smoke(self):
                 assert result.exit_code in (
                     ExitCode.FAILED_CONVERT, ExitCode.NO_INPUT), file_path
 
+    @pytest.mark.parametrize(["file_creator", "expected"], [
+        [valid_excel_file_1, ExitCode.SUCCESS],
+    ])
+    def test_normal_one_file(self, file_creator, expected):
+        db_path = "test.sqlite"
+        runner = CliRunner()
+
+        with runner.isolated_filesystem():
+            file_path = file_creator()
+            result = runner.invoke(
+                cmd, ["file", file_path, "-o", db_path])
+
+            assert result.exit_code == expected, file_path
+
     def test_normal_multi_file_different_table(self):
         db_path = "test.sqlite"
         runner = CliRunner()