Modify pytest.mark.skipif conditions

thombashi · Feb 12, 2020 · b3e4987 · b3e4987
1 parent 0160b84
commit b3e4987
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/test/test_subproc_runner.py b/test/test_subproc_runner.py
@@ -50,7 +50,7 @@ def test_normal(self, command, dry_run, expected):
 
         assert r.returncode in expected
 
-    @pytest.mark.skipif("platform.system() == 'Windows'")
+    @pytest.mark.skipif(platform.system() == "Windows", reason="platform dependent tests")
     @pytest.mark.parametrize(
         ["command", "expected"], [[list_command + " -l", 0], [[list_command, "-l"], 0]]
     )
@@ -70,7 +70,7 @@ def test_stdout(self, command, expected):
         assert runner.stdout.strip() == expected
         assert is_null_string(runner.stderr)
 
-    @pytest.mark.skipif("platform.system() == 'Windows'")
+    @pytest.mark.skipif(platform.system() == "Windows", reason="platform dependent tests")
     @pytest.mark.parametrize(
         ["command", "ignore_stderr_regexp", "out_regexp", "expected"],
         [
@@ -108,7 +108,7 @@ def test_stderr(self, capsys, command, ignore_stderr_regexp, out_regexp, expecte
         actual = out_regexp.search(err) is not None
         assert actual == expected
 
-    @pytest.mark.skipif("platform.system() == 'Windows'")
+    @pytest.mark.skipif(platform.system() == "Windows", reason="platform dependent tests")
     @pytest.mark.parametrize(
         ["command", "ignore_stderr_regexp", "expected"],
         [
@@ -147,7 +147,7 @@ def test_normal(self, command, environ, expected):
         assert is_null_string(ret_stderr)
         assert proc.returncode == expected
 
-    @pytest.mark.skipif("platform.system() == 'Windows'")
+    @pytest.mark.skipif(platform.system() == "Windows", reason="platform dependent tests")
     @pytest.mark.parametrize(["command", "pipe_input", "expected"], [["grep a", b"aaa", 0]])
     def test_normal_stdin(self, command, pipe_input, expected):
         proc = SubprocessRunner(command).popen(PIPE)

diff --git a/test/test_which.py b/test/test_which.py
@@ -3,7 +3,7 @@
 """
 
 
-import platform  # noqa: W0611
+import platform
 import re
 
 import pytest
@@ -28,7 +28,7 @@ def test_exception(self, value, expected):
 
 
 class Test_Which_repr:
-    @pytest.mark.skipif("platform.system() == 'Windows'")
+    @pytest.mark.skipif(platform.system() == "Windows", reason="platform dependent tests")
     @pytest.mark.parametrize(
         ["value", "expected_regexp"],
         [
@@ -44,7 +44,7 @@ def test_normal(self, value, expected_regexp):
 
 
 class Test_Which_is_exist:
-    @pytest.mark.skipif("platform.system() == 'Windows'")
+    @pytest.mark.skipif(platform.system() == "Windows", reason="platform dependent tests")
     @pytest.mark.parametrize(
         ["value", "expected"], [["ls", True], ["/bin/ls", True], ["__not_exist_command__", False]]
     )
@@ -61,7 +61,7 @@ def test_normal_windows(self, value, expected):
 
 
 class Test_Which_verify:
-    @pytest.mark.skipif("platform.system() == 'Windows'")
+    @pytest.mark.skipif(platform.system() == "Windows", reason="platform dependent tests")
     @pytest.mark.parametrize(["value"], [["ls"]])
     def test_normal_linux(self, value):
         Which(value).verify()
@@ -80,7 +80,7 @@ def test_exception(self, value, expected):
 
 
 class Test_Which_abspath:
-    @pytest.mark.skipif("platform.system() == 'Windows'")
+    @pytest.mark.skipif(platform.system() == "Windows", reason="platform dependent tests")
     @pytest.mark.parametrize(["value"], [["ls"]])
     def test_normal_linux(self, value):
         assert is_not_null_string(Which(value).abspath())