Instantiation of ValidatorFactory leads to performance issues

[benjaminknauer]

Hi 👋

My team used your book on clean architecture as reference for implementing new microservices. We absolutely love your book and the architecture approach.

Nevertheless, we want to share a major performance issue we encountered while using your template for the SefValidating abstract class:
During load testing, we noticed that our application used a lot of memory and requests took a long time even under small loads. Using profiling, we noticed that creating a ValidatorFactory during instantiation of every domain object was the problem.
We solved the issue by adding the ValidatorFactory as a static attribute in the abstract class.

Cheers,
Benjamin

buckpal/src/main/java/io/reflectoring/buckpal/common/SelfValidating.java

Lines 14 to 17 in f5a9be5

	public SelfValidating() {
	ValidatorFactory factory = Validation.buildDefaultValidatorFactory();
	validator = factory.getValidator();
	}

[thombergs]

Good find, thank you.

I was aware that this is not the most performant solution, but didn't think it would have that big of an impact.