Disable Gravatar #37
Disable Gravatar #37
Conversation
thomiceli
commented
May 18, 2023
thomiceli
commented
- If user is using an OAuth provider, use this avatar url, else
- If Gravatar is enabled and user has set an email, use Gravatar url, else
- Use default avatar
|
@josefandersson thoughts ? |
| userMap := make(map[string]*User) | ||
|
|
||
| err := db. | ||
| Where("email IN ?", emails). |
There was a problem hiding this comment.
Are emails normalized in db or will this create issues with capitalization? A normalizedEmail field in db may be good otherwise? For this use-case and when looking up by email in the future.
There was a problem hiding this comment.
You're right it might create issues ; the current email field in db should contain only lowercase emails, and the fetched emails in commits would be set as lowercase.
There was a problem hiding this comment.
I think so. I also think it's best to save the original email also, and not just a normalized one--hence why I would recommend a normalizedEmail field rather than normalizing the current email field. Emails can technically be case sensitive and it could technically screw with future email notification/sending functionality if the original is not kept.
There was a problem hiding this comment.
Your way of doing it makes good enough sense for the scale of this project. Same with not bothering to care about migrating old emails in db to lowercase. Maybe in a few years it's a different story. :)
* Disable Gravatar * Lowercase emails * Add migration
