Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported custom fields #2

Merged
merged 2 commits into from Aug 31, 2020
Merged

Supported custom fields #2

merged 2 commits into from Aug 31, 2020

Conversation

nnseva
Copy link
Contributor

@nnseva nnseva commented Jul 28, 2020

The supported field types list was restricted. This PR allows extending this list.

@nnseva nnseva force-pushed the custom-field-type-list branch 2 times, most recently from d4f6756 to f56fbfa Compare July 30, 2020 08:37
@thomst thomst merged commit f6000d8 into thomst:master Aug 31, 2020
@thomst
Copy link
Owner

thomst commented Aug 31, 2020

@nnseva: Thank you for the pull request.
Actually I plan to refactor the supported-field logic. We probably don't need this kind of restriction, if we just check for subclasses of models.Field and exclude ForeignKeys and ManyToManyFields. All fields that are not a relation of any kind should return a value that makes sense as csv-column.

But for now your solution is fine.

@thomst
Copy link
Owner

thomst commented Sep 2, 2020

Version 1.7 supports custom fields without the need to list them in the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nnseva @thomst