Skip to content

Commit

Permalink
ci: fix typescript checks
Browse files Browse the repository at this point in the history
  • Loading branch information
thomvaill committed Sep 23, 2022
1 parent f7fd0b0 commit 37187fc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ jobs:
run: yarn install --frozen-lockfile
# End of yarn setup

- name: typescript checks
run: yarn typescript

# We have to build all the packages before the tests
# Because init-log4brains's integration tests use @log4brains/cli, which uses @log4brains/core
# TODO: we should separate tests that require built packages of the others, to get a quicker feedback
Expand All @@ -130,6 +127,9 @@ jobs:
yarn link-cli
echo "$(yarn global bin)" >> $GITHUB_PATH
- name: typescript checks
run: yarn typescript

- name: test
run: yarn test

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,6 @@ jobs:
# - steps.yarn-lock.outcome == 'success' --> yarn.lock was not changed
# - steps.yarn-lock.outcome == 'failure' --> yarn.lock was changed

- name: typescript checks
run: yarn typescript

# We have to build all the packages before the tests
# Because init-log4brains's integration tests use @log4brains/cli, which uses @log4brains/core
# TODO: we should separate tests that require built packages of the others, to get a quicker feedback
Expand All @@ -132,6 +129,9 @@ jobs:
yarn link-cli
echo "$(yarn global bin)" >> $GITHUB_PATH
- name: typescript checks
run: yarn typescript

- name: test changed packages
if: ${{ steps.yarn-lock.outcome == 'success' }}
run: yarn test --since origin/master
Expand Down

0 comments on commit 37187fc

Please sign in to comment.