Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debian, pip3 and geerlinguy's packages #13

Merged
merged 5 commits into from Oct 3, 2022
Merged

Update debian, pip3 and geerlinguy's packages #13

merged 5 commits into from Oct 3, 2022

Conversation

ax0n-pr1me
Copy link

Description

Update packages to handle new versions of geerlingguy.pip and geerlinguy.docker.
Handle pip3 for previous updates
Update debian image for vagrant deployment to use current stable release
Update ReadMe to support quick start out of the box as intended.

Motivation and Context

The default instructions no longer work.

closes #11

(Thank you @ivoba)

How Has This Been Tested?

I have tested this in the vanilla repo as well as in my own application.

NOTE: the make test all passes with the exception of the tests that rely on shunit2.sh but I believe this to be a separate issue related to @kward 's awesome https://github.com/kward/shunit2. Updating the shunit2.sh file to the new version was not a simple fix and I did not need to work through these to be confident in the small changes submitted in this pull request.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes. - Not possible due to note above.
  • All new and existing tests passed. - See note above

@thomvaill
Copy link
Owner

Thanks a lot!

@thomvaill thomvaill merged commit a0d02b6 into thomvaill:master Oct 3, 2022
@ax0n-pr1me
Copy link
Author

💪💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geerlinguy ansible role versions
2 participants