Skip to content

Commit

Permalink
run npm 5.4.0 in CI (facebook#3026)
Browse files Browse the repository at this point in the history
* run npm 5.4.0 in CI

* run npm cache clean with --force in CI

* use link instead of install

* Update e2e-installs.sh

* Update e2e-kitchensink.sh

* Update e2e-simple.sh
  • Loading branch information
viankakrisna authored and thongdong7 committed Sep 24, 2017
1 parent 888c541 commit 7470ae3
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions tasks/e2e-installs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,11 @@ fi

if hash npm 2>/dev/null
then
# npm 5 is too buggy right now
# npm 5.0-5.4.0 is too buggy
if [ $(npm -v | head -c 1) -eq 5 ]; then
npm i -g npm@^4.x
npm i -g npm@^5.4.1
fi;
npm cache clean || npm cache verify
npm cache clean --force || npm cache verify
fi

# Prevent bootstrap, we only want top-level dependencies
Expand Down
6 changes: 3 additions & 3 deletions tasks/e2e-kitchensink.sh
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@ fi

if hash npm 2>/dev/null
then
# npm 5 is too buggy right now
# npm 5.0-5.4.0 is too buggy
if [ $(npm -v | head -c 1) -eq 5 ]; then
npm i -g npm@^4.x
npm i -g npm@^5.4.1
fi;
npm cache clean || npm cache verify
npm cache clean --force || npm cache verify
fi

# Prevent bootstrap, we only want top-level dependencies
Expand Down
6 changes: 3 additions & 3 deletions tasks/e2e-simple.sh
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,11 @@ fi

if hash npm 2>/dev/null
then
# npm 5 is too buggy right now
# npm 5.0-5.4.0 is too buggy
if [ $(npm -v | head -c 1) -eq 5 ]; then
npm i -g npm@^4.x
npm i -g npm@^5.4.1
fi;
npm cache clean || npm cache verify
npm cache clean --force || npm cache verify
fi

# Prevent bootstrap, we only want top-level dependencies
Expand Down

0 comments on commit 7470ae3

Please sign in to comment.