Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to retrieve environment config for socket.io use case #201

Merged
merged 5 commits into from May 12, 2022

Conversation

heyweswu
Copy link
Contributor

@heyweswu heyweswu commented Sep 17, 2021

Problem:

as of https://github.com/thoov/ember-websockets/releases/tag/8.0.0 if setting socketIO to true, the addon doesn't import socket.io-client and the resulting error is described here in #172

PR details

I'm proposing a change to properly retrieve the values from config/environment.js so that when setting the block below, socket.io-client gets properly imported

'ember-websockets': {
  'socketIO': true
}

Closes #172

@heyweswu
Copy link
Contributor Author

@thoov are you still maintaining this repo? if so, i'll also throw up a PR to bump mock-socket to the latest

@RobbieTheWagner RobbieTheWagner merged commit 9291fa6 into thoov:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: io is not defined
2 participants