fix to retrieve environment config for socket.io use case #201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
as of https://github.com/thoov/ember-websockets/releases/tag/8.0.0 if setting
socketIO
to true, the addon doesn't importsocket.io-client
and the resulting error is described here in #172PR details
I'm proposing a change to properly retrieve the values from config/environment.js so that when setting the block below,
socket.io-client
gets properly importedCloses #172