New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix normalize-send when sending object data, add test #286

Open

viggyfresh wants to merge 2 commits into thoov:master from curai:master

viggyfresh commented Nov 8, 2019

This should close Socket.IO Emit args serialized to string #245
However...I am not sure if this is actually desired behavior for non-socketIO clients - but I'm pretty sure the native browser WebSocket spec only supports sending stringified messages, so this is probably OK to merge

viggyfresh added 2 commits

November 7, 2019 21:45


          Fix normalize-send when sending object data, add test

efee598


          Bump version, version control dist

8a2d8eb

gCardinal mentioned this pull request

Emitting with object as payload converts the object to a string #297

Open

sunsheeppoplar commented Sep 17, 2020

Thanks for putting this pull up, @viggyfresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment