Do not normalize data when emitting to socket.io sockets #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atrue
requested changes
Feb 14, 2023
Frank3K
commented
Feb 14, 2023
Atrue
approved these changes
Feb 14, 2023
|
Thanks for your quick response. Appreciated. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for keeping this package maintained!
This PR is a follow-up from #246, where this issue has already been discussed 1.5 years ago. We lost track of that PR (by @thomasdunn) and want to submit it again in a proper form such that it can merged in master.
Note that this code has been running in our own fork for about 1.5 years without any issues.