Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding customized function... option.. #8

Merged
merged 4 commits into from Mar 27, 2017
Merged

adding customized function... option.. #8

merged 4 commits into from Mar 27, 2017

Conversation

ghost
Copy link

@ghost ghost commented Mar 22, 2017

No description provided.

@ghost ghost changed the title syncing.. adding customized function... option.. Mar 22, 2017
@thoppe
Copy link
Owner

thoppe commented Mar 22, 2017

Hi @SoftwareMechanic, this looks like it could be useful addition but the checks failed. Can you

  1. Fix the errors in the continuous integration (I used tox on this project, if it passes locally it should pass on Travis CI). The errorlog for your patch is here https://travis-ci.org/thoppe/python-hyperoperators/jobs/213830838
  2. Describe a use case for a custom function so we can add it to the README.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 94.624% when pulling fb97f68 on softwaremechanic:master into a5d0cd6 on thoppe:master.

@ghost
Copy link
Author

ghost commented Mar 23, 2017

1.Fix the errors.

Well everything except one seem fixed now. For some reason i can't pass kwargs to base_hyperop0.. I'm missing some python internals..

  1. Use case for a custom function.

I wanted to be able to apply the reduction/exponentiation functions on more than addition as the base case.
So effectively I wanted to say define the base case as say, subtraction and see if we can make it generic.(so hyper op 1 becomes division, 2 becomes log etc..)

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.4%) to 94.624% when pulling 1f92a7c on softwaremechanic:master into a5d0cd6 on thoppe:master.

@thoppe
Copy link
Owner

thoppe commented Mar 27, 2017

@SoftwareMechanic I don't have the time to write tests for a customFunction, mostly since I'd like to see your use case. Either way, that brings the coverage down, which is why the build fails. I'm happy to merge it anyways, since it doesn't seem to cause any harm to the existing code.

If you're doing a project with this, please let me know! I'm interested to see what comes out of it.

@thoppe thoppe merged commit ded7b49 into thoppe:master Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants