This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
THORN-2064, update to use smallrye-jwt 1.1.0 implementation, redo #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
reviewed
Jul 18, 2018
| @@ -25,6 +25,7 @@ | |||
| <swarm.fraction.stability>stable</swarm.fraction.stability> | |||
| <swarm.fraction.tags>Eclipse MicroProfile,JWT,Security,Web</swarm.fraction.tags> | |||
| <version.jose4j>0.6.0</version.jose4j> | |||
| <version.smallrye.jwt>1.1.0</version.smallrye.jwt> | |||
There was a problem hiding this comment.
This should go into the build-parent pom: https://github.com/thorntail/thorntail/blob/master/build-parent/pom.xml#L114-L116
There was a problem hiding this comment.
Not really. You've only copied the version property to build-parent. The property here should be removed. Also io.smallrye:smallrye-jwt dependency should be added to <dependencyManagement> section in build-parent; there is a <!-- SmallRye --> comment where other MPs reside.
kenfinnigan
previously approved these changes
Jul 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvn clean install?A redo of the previous pull request from a fresh repo rebased to upstream.