This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
THORN-2460: thorntail.classpath system property can be used also for … #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uberjars Motivation ---------- Documentation is not very clear about using external JDBC drivers. It suggests that the thorntail.classpath property can be used only with hollow JARs, which is not true. Improve wording so it is clear that it can be used for both hollow JARs and uberjars. Modifications ------------- Reworded and renamed the section about specifying JDBC drivers via the thorntail.classpath system property. Result ------ Better user experience when reading the documentation.
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Ladicek
reviewed
Aug 26, 2019
|
ok to test |
1 similar comment
|
ok to test |
Co-Authored-By: Ladislav Thon <ladicek@gmail.com>
Ladicek
approved these changes
Aug 26, 2019
|
Probably 2 random fails on Linux? |
|
Linux failures are |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uberjars
Motivation
Documentation is not very clear about using external JDBC drivers.
It suggests that the thorntail.classpath property can be used only
with hollow JARs, which is not true. Improve wording so it is clear
that it can be used for both hollow JARs and uberjars.
Modifications
Reworded and renamed the section about specifying JDBC drivers
via the thorntail.classpath system property.
Result
Better user experience when reading the documentation.
mvn clean install?@Ladicek this is the promised documentation PR about the usage of
thorntail.classpathsystem property. Should you have any suggestions about better wording, just let me know.