This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
SWARM-610: The wildfly-self-contained.d directory lingers #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiko-braun
commented
Nov 10, 2016
| @@ -43,6 +43,7 @@ | |||
| <version.org.jboss.msc.jboss-msc>1.2.6.Final</version.org.jboss.msc.jboss-msc> | |||
| <version.jboss-logmanager-ext>1.0.0.Alpha3</version.jboss-logmanager-ext> | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
This shouldn't be here, but since I am travelling this week, maybe we can just it ignore it?
kenfinnigan
reviewed
Nov 10, 2016
| this.serviceContainer.addTerminateListener(info -> latch.countDown()); | ||
| this.serviceContainer.shutdown(); | ||
|
|
||
| latch.await(); |
There was a problem hiding this comment.
As we're not using this.serviceContainer as part of the stop() anymore, do we even need to hang onto the object?
Looks like, from a quick glance, that we can remove the instance from the class and use locally on start
|
i've included @kenfinnigan suggestions. retest this please |
Some files lingers in the tmp directpry when the process stops Modifications Change the StandaloneContainerImpl to manage the tmp directory explicitly and provide a stop() to shutdown the container. Result All allocated tmp files will be properly removed when Swarm stops.
heiko-braun
force-pushed
the
SWARM-610
branch
from
52e0c50
to
c3d7dfd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvn clean install?Motivation
Some files lingers in the tmp directory when the process stops
Modifications
Change the WF Core StandaloneContainer to manage the tmp directory explicitly and provide a stop() to shutdown the container.
Result
All allocated tmp files will be properly removed when Swarm stops.