This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
SWARM-793 - module.xml and resource-root #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- For people who provide their own module.xml's for whatever reason, supporting <resource-root> for .jars didn't work; only when we used <artifact>. Modifications ------------- Better inspection of the module.xml and setting up the correct resource-loader if the resource is actually a .jar. Result ------ Jars should work now as <resource-root> elements within a user-provided module.xml
kenfinnigan
approved these changes
Dec 7, 2016
Ladicek
added a commit
to Ladicek/thorntail
that referenced
this pull request
May 22, 2020
This is to fix several NPEs: - smallrye/smallrye-open-api#248 - smallrye/smallrye-open-api#237 For thorntail#248, see also: - smallrye/smallrye-open-api#251 - https://issues.redhat.com/browse/WFLY-13127 - smallrye/smallrye-open-api#290 For thorntail#237, see also: - smallrye/smallrye-open-api#325
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvn clean install?Motivation
For people who provide their own module.xml's for whatever
reason, supporting for .jars didn't work;
only when we used .
Modifications
Better inspection of the module.xml and setting up the
correct resource-loader if the resource is actually a .jar.
Result
Jars should work now as elements within
a user-provided module.xml