Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume "louder / turn volume up / down" #85

Open
Flacedoo opened this issue May 25, 2021 · 1 comment
Open

Volume "louder / turn volume up / down" #85

Flacedoo opened this issue May 25, 2021 · 1 comment

Comments

@Flacedoo
Copy link

Flacedoo commented May 25, 2021

Hi everyone,

Would it be possible to integrate a volume up / down command, instead of just having to set it to a fixed value? Normally when I'm listening to music I've got no idea to what level it is currently set, and I just want to turn it up or down. I dug around the Spotify api a little, and it seems like the "GET https://api.spotify.com/v1/me/player" can output the current set volume. Therefore it would be just to read it, and then add / subtract e.g. 15 to / from it.

Normally I would just have created a pull request - but I've never developed an Alexa skill nor anything in nodejs.. Therefore if someone here would be willing to put that effort in I would highly appreciate it! For sure I'm happy to help digging around and try to solve issues.

Cheers,
Flacedoo

@thorpelawrence
Copy link
Owner

thorpelawrence commented May 25, 2021

Hey there @Flacedoo,

Unfortunately I don't think I'll be able to implement this as I've been quite busy recently, but if as you say it looks like a simple GET request, you could probably reuse something like this line with the new endpoint, and just reuse the whole of the VolumeLevelIntent/VolumePercentIntent but using the +/-1 volume instead.

If you or someone would be willing to open a PR, I would be happy to review it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants