refactor: corrected types

thorsten · Mar 30, 2024 · 042286a · 042286a
1 parent 5336353
commit 042286a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/phpmyfaq/src/phpMyFAQ/Search/AbstractSearch.php b/phpmyfaq/src/phpMyFAQ/Search/AbstractSearch.php
@@ -32,7 +32,7 @@ abstract class AbstractSearch
      *
      * @var stdClass[]
      */
-    protected $resultSet;
+    protected mixed $resultSet;
 
     /**
      * AbstractSearch constructor.

diff --git a/phpmyfaq/src/phpMyFAQ/Search/SearchDatabase.php b/phpmyfaq/src/phpMyFAQ/Search/SearchDatabase.php
@@ -85,7 +85,7 @@ public function search(string $searchTerm): mixed
             FROM 
                 %s %s %s
             WHERE
-                %s = %d',
+                %s = %s',
             $this->getResultColumns(),
             $this->getTable(),
             $this->getJoinedTable(),

diff --git a/phpmyfaq/src/phpMyFAQ/Search/SearchFactory.php b/phpmyfaq/src/phpMyFAQ/Search/SearchFactory.php
@@ -30,9 +30,9 @@ class SearchFactory
     /**
      * Factory for generating search instances.
      *
-     * @param string[] $searchHandler Array with search handlers, e.g. array('database' => 'mysqli')
+     * @param string[] $searchHandler Array with search handlers, e.g., array ('database' => 'mysqli')
      */
-    public static function create(Configuration $configuration, array $searchHandler): DatabaseInterface
+    public static function create(Configuration $configuration, array $searchHandler): SearchDatabase
     {
         $searchClass = sprintf(
             '\phpMyFAQ\Search\%s\%s',

diff --git a/tests/phpMyFAQ/RelationTest.php b/tests/phpMyFAQ/RelationTest.php
@@ -19,6 +19,8 @@ public function testGetAllRelatedByQuestion(): void
         $dbHandle = new Sqlite3();
         $dbHandle->connect(PMF_TEST_DIR . '/test.db', '', '');
         $configuration = new Configuration($dbHandle);
+        $configuration->set('search.enableRelevance', false);
+
         $language = new Language($configuration);
         $language->setLanguage(false, 'en');
         $configuration->setLanguage($language);