fix: added missing conversion to HTML entities

thorsten · Mar 2, 2024 · 09336b0 · 09336b0
1 parent 7dc4b98
commit 09336b0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/phpmyfaq/admin/user.php b/phpmyfaq/admin/user.php
@@ -573,8 +573,8 @@ class="form-check-input permission">
                 <tr class="row_user_id_<?= $user->getUserId() ?>">
                     <td><?= Strings::htmlentities($user->getUserData('display_name')) ?></td>
                     <td>
-                        <a href="mailto:<?= $user->getUserData('email') ?>">
-                            <?= $user->getUserData('email') ?>
+                        <a href="mailto:<?= Strings::htmlentities($user->getUserData('email')) ?>">
+                            <?= Strings::htmlentities($user->getUserData('email')) ?>
                         </a>
                     </td>
                     <td><?= Strings::htmlentities($user->getLogin()) ?></td>

diff --git a/phpmyfaq/ucp.php b/phpmyfaq/ucp.php
@@ -78,7 +78,7 @@
             'msgRealName' => Translation::get('ad_user_name'),
             'realname' => Strings::htmlentities($user->getUserData('display_name')),
             'msgEmail' => Translation::get('msgNewContentMail'),
-            'email' => $user->getUserData('email'),
+            'email' => Strings::htmlentities($user->getUserData('email')),
             'msgIsVisible' => Translation::get('ad_user_data_is_visible'),
             'checked' => (int)$user->getUserData('is_visible') === 1 ? 'checked' : '',
             'msgPassword' => Translation::get('ad_auth_passwd'),