feat(http-client): added timeout of 30 sec

thorsten · Mar 20, 2024 · 80c5d9a · 80c5d9a
1 parent edfc777
commit 80c5d9a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/phpmyfaq/src/phpMyFAQ/Administration/Api.php b/phpmyfaq/src/phpMyFAQ/Administration/Api.php
@@ -49,7 +49,7 @@ class Api
      */
     public function __construct(private readonly Configuration $configuration)
     {
-        $this->setHttpClient(HttpClient::create(['max_redirects' => 2]));
+        $this->setHttpClient(HttpClient::create(['max_redirects' => 2, 'timeout' => 30]));
     }
 
     /**

diff --git a/phpmyfaq/src/phpMyFAQ/Controller/Administration/UpdateController.php b/phpmyfaq/src/phpMyFAQ/Controller/Administration/UpdateController.php
@@ -85,7 +85,7 @@ public function versions(): JsonResponse
         $this->userIsAuthenticated();
 
         try {
-            $versions = HttpClient::create()->request(
+            $versions = HttpClient::create(['timeout' => 30])->request(
                 'GET',
                 'https://api.phpmyfaq.de/versions'
             );

diff --git a/phpmyfaq/src/phpMyFAQ/Setup/Upgrade.php b/phpmyfaq/src/phpMyFAQ/Setup/Upgrade.php
@@ -137,7 +137,7 @@ public function downloadPackage(string $version): string
     {
         $url = $this->getDownloadHost() . $this->getPath() . $this->getFilename($version);
 
-        $client = HttpClient::create();
+        $client = HttpClient::create(['timeout' => 30]);
 
         try {
             $response = $client->request('GET', $url);
@@ -170,7 +170,7 @@ public function downloadPackage(string $version): string
      */
     public function verifyPackage(string $path, string $version): bool
     {
-        $httpClient = HttpClient::create();
+        $httpClient = HttpClient::create(['timeout' => 30]);
         $response = $httpClient->request(
             'GET',
             DownloadHostType::PHPMYFAQ->value . 'info/' . $version