Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Star Rating and Facebook icon #800

Closed
tomperys opened this issue Jan 23, 2014 · 10 comments
Closed

Star Rating and Facebook icon #800

tomperys opened this issue Jan 23, 2014 · 10 comments
Assignees
Labels
Milestone

Comments

@tomperys
Copy link

Hi,
pleas the FAQ can' t be rated. When you click on the stars, nothing will happend. I have no idea why else this doesn't work :( I had 2.8.4 now upgraded to 2.8.5 but still the rating didnt work.

The facebook icon is second problem. When you click on it, it will just open the blank white page. Under the icon is red text "Error" and when I click on that, small FB window will open saying "The href URL is not properly formatted".

@ghost ghost assigned thorsten Jan 24, 2014
thorsten added a commit that referenced this issue Jan 24, 2014
@thorsten
Copy link
Owner

Cannot reproduce the second issue, sorry.

@tomperys
Copy link
Author

Tried to change that file and put only:

// Check captcha
$captcha = new PMF_Captcha($faqConfig);
$captcha->setSessionId(PMF_Filter::filterInput(INPUT_COOKIE, PMF_Session::PMF_COOKIE_NAME_SESSIONID, FILTER_VALIDATE_INT));

But still, the rating dont work :(

@thorsten
Copy link
Owner

Do you get any JS errors? Can I check your FAQ?

@tomperys
Copy link
Author

Yes you can, address is htp://faq.ignum.cz I believe you have also admin account there already.

@thorsten
Copy link
Owner

You have an JS error on your page which breaks the star rating:

TypeError: $(...).tooltip is not a function
$('a[rel="tooltip"]').tooltip();

@tomperys
Copy link
Author

Ok but thats a part of "artikel.tpl" ...I even try to change ot for "artikel.tpl" from the default templates (in case there was some change) but still the error is there so have no idea how to fix that :(

@thorsten
Copy link
Owner

Did you also update the phpmyfaq.js file?

@tomperys
Copy link
Author

Yes I copied everything from the 2.8.5 archive. The only thing I didnt change was my own template folder

@thorsten
Copy link
Owner

I think I changed something in the artikel.tpl template: https://github.com/thorsten/phpMyFAQ/blob/2.8/CHANGEDFILES#L6

@tomperys
Copy link
Author

Thanks, works now :) Except the facebook, I must remove the icon completly, because it always opend only a blank window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants