Master #25
Master #25
Conversation
This is a first attemps to control the length of detected lines (issue . Two new parameters (minLength and maxLength) and a new Line method (prune) allow to remove lines that have not the correct size. The new method does not alter the detected junction points (so that junction points are not in sync after lines removal).
|
Great! Thank you! I guess we should add the sync with the junction points before merging it into the master branch. I would like to keep the data consistent. |
…esponding junctions Adds the possibility to remove lines depending on their length and remove the corresponding junctions as well.
|
Hi, I reworked the code so that it now removes the junctions as well. I am not totally satisfied with the code as it needs two loops to do so (one to remove the junctions and one to remove the lines), but I couldn't find a way to do it in a single loop (it throws concurentModificationException). Btw, are you sure that your function deleteContour does not lead to concurentModificationException too ? My first plan was to use this function to remove both junctions and lines at the same time, but it always throws this exception. I don't have fully tested what happens with the ExtendLine option as I am not sure to understand what it does (it seems to shorten lines in some cases). |
the second loop. Replaced the deleteContour function with the deleteJunction function to avoid concurrentModificationException when deleting several contours at once.
|
It seems that with length selection, overlap resolution method SLOPE does not work anymore. I'll be looking into this. |
…lap resolver option SLOPE. This is a workaround to make the plugin works with line length control and overlap resolver option SLOPE. The problem arises from an inconsistency between the content of junctions cont1 and cont2 when using overlapOption.NONE or overlapOption.SLOPE. In the first case, cont1 and cont2 refers to lines indices in the Arraylist, while in the second case, cont1 and cont2 refers to lines ID. The commit makes the plugin works, but the kept junctions are still inconsistent with the removed lines when SLOPE is selected.
|
Very nice! Thanks. |
Changed makeBinary function to also draw estimated width when Estimate Width is ticked. When applying the plugin on a multi stack Composite image, the binary image produced contains the same number of channels and slices than the original image, each containing a binary image of the detected lines. LUT of composite image is kept in binary image.
Hi, I made an attempt to control the length of detected lines (issue #4). Two new parameters (minLength and maxLength) and a new Line method
(prune) allow to remove lines that don’t have the correct size. The new
method does not alter the detected junction points (so that junction
points are not in sync after lines removal).