feat: core plugin approve handling (#779)

thorswap · May 6, 2024 · acf1100 · acf1100
1 parent 547e4b2
commit acf1100
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/.changeset/good-rules-hide.md b/.changeset/good-rules-hide.md
@@ -0,0 +1,6 @@
+---
+"@swapkit/helpers": patch
+"@swapkit/core": patch
+---
+
+Fixes core plugin approval handling
diff --git a/packages/swapkit/core/src/client.ts b/packages/swapkit/core/src/client.ts
@@ -113,8 +113,18 @@ export function SwapKit<
   }) {
     const plugin = availablePlugins[spenderAddress];
 
-    if (plugin && "approve" in plugin) {
-      return plugin.approve({ assetValue, type }) as ApproveReturnType<T>;
+    if (plugin) {
+      if (type === ApproveMode.CheckOnly && "isAssetValueApproved" in plugin) {
+        return plugin.isAssetValueApproved({ assetValue }) as ApproveReturnType<T>;
+      }
+      if (type === ApproveMode.Approve && "approveAssetValue" in plugin) {
+        return plugin.approveAssetValue({ assetValue }) as ApproveReturnType<T>;
+      }
+
+      throw new SwapKitError(
+        "core_approve_asset_target_invalid",
+        `Target ${String(spenderAddress)} cannot be used for approve operation`,
+      );
     }
 
     const { address, chain, isGasAsset, isSynthetic } = assetValue;

diff --git a/packages/swapkit/helpers/src/modules/swapKitError.ts b/packages/swapkit/helpers/src/modules/swapKitError.ts
@@ -9,6 +9,7 @@ const errorMessages = {
   core_approve_asset_address_or_from_not_found: 10005,
   core_plugin_not_found: 10006,
   core_plugin_swap_not_found: 10007,
+  core_approve_asset_target_invalid: 10008,
   core_chain_halted: 10099,
 
   /**